[Asterisk-code-review] translate: Provide translation modules the result of SDP neg... (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed Nov 11 09:29:56 CST 2015


Joshua Colp has posted comments on this change.

Change subject: translate: Provide translation modules the result of SDP negotiation.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1598/1/main/translate.c
File main/translate.c:

Line 335: 	pvt->f.subclass.format = ao2_bump(format);
> Is that newpvt anyhow threaded? Otherwise, I could move the reference bump 
Are you wanting to pass in the format all the way for usage in a newpvt callback?


-- 
To view, visit https://gerrit.asterisk.org/1598
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6878a989b50573298dab115d3371ea369e1a718
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list