[Asterisk-code-review] translate: Provide translation modules the result of SDP neg... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: translate: Provide translation modules the result of SDP negotiation.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1598/1/main/translate.c
File main/translate.c:

Line 335: 	pvt->f.subclass.format = ao2_bump(format);
> Previously it was possible for the newpvt callback to set the pvt->f.subcla
Is that newpvt anyhow threaded? Otherwise, I could move the reference bump after calling the other newpvt. Then, I could compare both objects. If they are not the same, I do not bump. If it is the same, I bump.

On the other side, if I set the whole format after newpvt, all (leveraging) transcoding modules have to be inited not in their newpvt but sometime afterwards. That is going to get terrible code and a lot of misunderstanding in future – just because of a corner case, nobody might using.


-- 
To view, visit https://gerrit.asterisk.org/1598
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6878a989b50573298dab115d3371ea369e1a718
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes