[Asterisk-code-review] translate: Provide translation modules the result of SDP neg... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: translate: Provide translation modules the result of SDP negotiation.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/1598/1/main/translate.c
File main/translate.c:

Line 335: 	pvt->f.subclass.format = ao2_bump(format);
> Otherwise, all transcoding modules (which require the negotiated SDP result
Previously it was possible for the newpvt callback to set the pvt->f.subclass.format to whatever it wanted, and because it was new there was no format previously. Now this is no longer true. A format may be there and unless it calls ao2_cleanup on it, it'll leak a reference.


Line 488: 		if ((t->dst_codec.sample_rate != ast_format_get_sample_rate(dst)) || (strcmp(t->dst_codec.name, ast_format_get_name(dst)))) {
> I added the type checking.
I'm not swayed either way, but it would have consolidated all the changes in one place.


-- 
To view, visit https://gerrit.asterisk.org/1598
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6878a989b50573298dab115d3371ea369e1a718
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes