[Asterisk-code-review] translate: Provide translation modules the result of SDP neg... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: translate: Provide translation modules the result of SDP negotiation.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/1598/1/main/translate.c
File main/translate.c:

Line 335: 	pvt->f.subclass.format = ao2_bump(format);
> This changes the contract of the newpvt callback. Previously newpvt never e
Otherwise, all transcoding modules (which require the negotiated SDP result) have to initialise themselves not in newpvt but later (in framein/frameout). Is that what you want? Furthermore, I do not understand the "contract" you are about. Are you about the reference-count management?


Line 488: 		if ((t->dst_codec.sample_rate != ast_format_get_sample_rate(dst)) || (strcmp(t->dst_codec.name, ast_format_get_name(dst)))) {
> This is incomplete. You need to check name, type, and sample rate. You coul
I added the type checking.

I am not sure what you mean by moving. I moved what I think was meant by this comment – however, for me it is harder to read now. If I would not be the author of this change, I would have to double-check with the callers of newpvt why we check for destination here. Previously, we checked for dst and gave a dst.


-- 
To view, visit https://gerrit.asterisk.org/1598
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6878a989b50573298dab115d3371ea369e1a718
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes