[Asterisk-code-review] Increase account code maximum length to 80. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Increase account code maximum length to 80.
......................................................................


Patch Set 1:

> (1 comment)
 > 
 > This patch doesn't really fix the initial truncation complaint. 
 > The reporter said that he couldn't put a 20 char accountcode into
 > the database without it being truncated to 19 chars because of the
 > need for a null terminator.  This patch just increases the size of
 > the accoutcode but doesn't eliminate the truncation from the
 > advertised max len.  With this patch, you can now store a maximum
 > of 79 from the advertised 80 for the same reason.  However, this is
 > consistent with every other max size string advertised since you
 > can only store a string of one less than the advertised max len.

I'm not sure if it would be better to add room for null terminators in Asterisk or to cut the database fields down by 1 character.  I don't think this commit resolves the original issue, it's just related.  That's why I didn't include the #close.  For now I felt being consistent with everything else was better than having accountcode be the only one that doesn't truncate.

-- 
To view, visit https://gerrit.asterisk.org/1570
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If122602304ce03362722eb213a3111b32da5eeb9
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No