[Asterisk-code-review] Increase account code maximum length to 80. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Thu Nov 5 14:19:37 CST 2015


Richard Mudgett has posted comments on this change.

Change subject: Increase account code maximum length to 80.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

This patch doesn't really fix the initial truncation complaint.  The reporter said that he couldn't put a 20 char accountcode into the database without it being truncated to 19 chars because of the need for a null terminator.  This patch just increases the size of the accoutcode but doesn't eliminate the truncation from the advertised max len.  With this patch, you can now store a maximum of 79 from the advertised 80 for the same reason.  However, this is consistent with every other max size string advertised since you can only store a string of one less than the advertised max len.

https://gerrit.asterisk.org/#/c/1570/1//COMMIT_MSG
Commit Message:

Line 13: ASTERISK-23904
Add #close
since this should resolve the issue.


-- 
To view, visit https://gerrit.asterisk.org/1570
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If122602304ce03362722eb213a3111b32da5eeb9
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list