[Asterisk-code-review] Fix segfault if Dial() is used on PJSIP and endpoint was uns... (asterisk[13])

[snuffy]

snuffy has posted comments on this change.

Change subject: Fix segfault if Dial() is used on PJSIP and endpoint was unspecified.
......................................................................


Patch Set 5:

> This fixes the problem at the wrong level. After looking at the
 > code there appears to be a missing "return -1;" in the request
 > function of chan_pjsip.c
 > 
 > When it outputs the error about an empty endpoint name it should
 > then return, as going further will cause the crash you see.

How did I not spot it.. testing with new patch for return -1 and reposting

-- 
To view, visit https://gerrit.asterisk.org/476
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de76c2935a1f4e3f0cffe97a670106f5605e89e
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: snuffy <snuffy22 at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: snuffy <snuffy22 at gmail.com>
Gerrit-HasComments: No