[Asterisk-code-review] Fix segfault if Dial() is used on PJSIP and endpoint was uns... (asterisk[13])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: Fix segfault if Dial() is used on PJSIP and endpoint was unspecified.
......................................................................


Patch Set 5: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/476/5//COMMIT_MSG
Commit Message:

Line 7: Fix segfault if Dial() is used on PJSIP and endpoint was unspecified.
Missing an article (an) and unspecified means "not stated clearly or precisely while not specified means "not stated at all" which is what I think you are wanting here:

Fix segfault if Dial() is used on PJSIP and an endpoint was not specified.


Line 9: This could happen when the dialplan variable for endpoint is not set,
Missing an article (an) and incorrectly using an article later ('an' should be 'a'):

This could happen when the dialplan variable for an endpoint is not set,
causing us to try to reference AORs of a non-existent endpoint.


Line 12: Change this to ensure we have endpoint before asking for its AORs.
Missing an article (an):

Change this to ensure we have an endpoint before asking for its AORs.


Line 15: 
Below the issue, you need to add (with a line break afterwards): 
Reported by: snuffy


-- 
To view, visit https://gerrit.asterisk.org/476
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de76c2935a1f4e3f0cffe97a670106f5605e89e
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: snuffy <snuffy22 at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes