[Asterisk-code-review] cel pgsql: Add support for setting schema (asterisk[master])

Rodrigo Ramirez Norambuena asteriskteam at digium.com
Tue May 12 09:30:36 CDT 2015


Rodrigo Ramirez Norambuena has posted comments on this change.

Change subject: cel_pgsql: Add support for setting schema
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.asterisk.org/#/c/120/7/cel/cel_pgsql.c
File cel/cel_pgsql.c:

Line 619: 			if (sscanf(flen, "%d", &int_flen) == 1 && int_flen == -1) {
        : 				/* For varchar columns, the maximum length is encoded in a different field */
        : 				flen = PQgetvalue(result, i, 5);
        : 			}
> Is this a different fix?
Initially was a port commit of 2d60b755 but the interation on the time the feature to will is changed.

This change could removed to this commit for to pass more cleaned. After i can do it other change for this.


-- 
To view, visit https://gerrit.asterisk.org/120
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I691fd2cbc277fcba10e615f5884f8de5d8152f2c
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list