[Asterisk-code-review] cel pgsql: Add support for setting schema (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: cel_pgsql: Add support for setting schema
......................................................................


Patch Set 7: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/120/7/CHANGES
File CHANGES:

Line 156: * Added support to set schema where located the table cel. This settings is
        :   configurable for cel_pgsql via the 'schema' in configuration file
        :   cel_pgsql.conf.
Needs spaces at the beginning.


https://gerrit.asterisk.org/#/c/120/7/cel/cel_pgsql.c
File cel/cel_pgsql.c:

Line 619: 			if (sscanf(flen, "%d", &int_flen) == 1 && int_flen == -1) {
        : 				/* For varchar columns, the maximum length is encoded in a different field */
        : 				flen = PQgetvalue(result, i, 5);
        : 			}
Is this a different fix?


https://gerrit.asterisk.org/#/c/120/7/configs/samples/cel_pgsql.conf.sample
File configs/samples/cel_pgsql.conf.sample:

Line 71: ;schema=public ;Schema where CEL's table is located. Optional parameter
       :                ;if have schema suport default used current_schema()
Optional parameter. If schema support is present the default value used will be current_schema()


-- 
To view, visit https://gerrit.asterisk.org/120
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I691fd2cbc277fcba10e615f5884f8de5d8152f2c
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes