[Asterisk-code-review] ARI: Added new functionality to load a single module. (asterisk[13])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change.

Change subject: ARI: Added new functionality to load a single module.
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.asterisk.org/#/c/807/7/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 207: response, 404, "Not Found",
        : 			"Module is not configured"
> Are these two different things? 
To me, it seems like this could go either way: 404 Not Found, going the route of "Module is not configured", because that's what the API states in the comments, or 409 Conflict, stating the same reason. The ast_module_load_result enum does not give any more information other than that, hence my "Module is not configured" response message. Configuration is also user error based, and they *should* know to check the configuration if this message is given. However, this seems to lean more towards a 409 at that point, and a 404 wouldn't have any other spot to fill, which is why I took it out in a previous review.


-- 
To view, visit https://gerrit.asterisk.org/807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes