[Asterisk-code-review] ARI: Added new functionality to load a single module. (asterisk[13])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to load a single module.
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/807/7/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 207: response, 404, "Not Found",
        : 			"Module is not configured"
Are these two different things? 

In other words, is 'Not found' != 'Module is not configured'? To me, they seem to imply two different states. I think that 'Not Found' is that we tried to load a module, and we couldn't find it in order to load it.

But since AST_MODULE_LOAD_DECLINE means that the module configuration could have been bad or that the module couldn't be found (and after searching the source, it looks like this could be caused from several other reasons as well), perhaps this error should simply state, 'Load Declined', with reason, 'Asterisk declined to load the module.'


https://gerrit.asterisk.org/#/c/807/7/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 75: "reason": "Module is not configured."
Paraphrasing my previous comment from resource_asterisk.c:

Since this is triggered from receiving an AST_MODULE_LOAD_DECLINE return code, and that code can mean a multitude of reasons, not just that the module was not configured, perhaps this reason should simply state, 'Asterisk declined to load the module.'


-- 
To view, visit https://gerrit.asterisk.org/807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes