[Asterisk-code-review] ARI: Added new functionality to load a single module. (asterisk[13])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change.

Change subject: ARI: Added new functionality to load a single module.
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.asterisk.org/#/c/807/6/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 194: 	ast_assert(response != NULL);
> Did you mean to remove the check that ensured the args->module_name was not
Yup! It was actually a mistake to add it in the first place; Asterisk won't let you make an http request without the entire path specified. For example, if you did something like 'ari/asterisk/modules/', it would give an error saying that requests can't end with '/', making it impossible for the argument to be NULL in this particular case. It would have been impossible to test on Scott's end as well.


-- 
To view, visit https://gerrit.asterisk.org/807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes