[Asterisk-code-review] ARI: Added new functionality to load a single module. (asterisk[13])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Added new functionality to load a single module.
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/807/6/res/ari/resource_asterisk.c
File res/ari/resource_asterisk.c:

Line 194: 	ast_assert(response != NULL);
Did you mean to remove the check that ensured the args->module_name was not empty?


https://gerrit.asterisk.org/#/c/807/6/rest-api/api-docs/asterisk.json
File rest-api/api-docs/asterisk.json:

Line 72: 					"errorResponses": [
Don't you still need a 404 to denote that the system could not find (and therefore could not load) the specified resource (module)?


-- 
To view, visit https://gerrit.asterisk.org/807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05d5b8c5c666ecfef341504f9edc1aa84fda33
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes