[Asterisk-code-review] chan sip: option 'notifyringing' change and doc fix (asterisk[master])

[Ward van Wanrooij]

Ward van Wanrooij has posted comments on this change.

Change subject: chan_sip: option 'notifyringing' change and doc fix
......................................................................


Patch Set 3:

> (1 comment)

Use case is this: Three people are responsible for incoming calls. All three have a separate BLF on the phone. In the default Asterisk implementation the BLF's will go to state early (flashing) whenever a call is incoming. It is however useful to see not if the colleagues' phones are ringing, but instead if they are busy, so to have the BLF's stay in state confirmed (on) instead of flashing. This is what the notifyringing option should do according to the default sip.conf.sample:
Control whether subscriptions already INUSE get sent
                                ; RINGING when another call is sent (default: yes)
However, it is implemented differently, if set to true, ringing indications are always sent, otherwise never sent.
This patch adds a third option "notinuse" that matches the current description. The implementation of this is easy, the implementation of notifyringing=yes is exactly equal to notifyringing=notinuse except when an extension is both ringing and in use, then it should be set to early when notifyringing=yes and set to confirmed when notifyringing=notinuse.

-- 
To view, visit https://gerrit.asterisk.org/1649
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88f7036ee084bb3f43b74f15612695c6708f74aa
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ward van Wanrooij <ward at ward.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Ward van Wanrooij <ward at ward.nu>
Gerrit-HasComments: No