[Asterisk-code-review] chan sip: option 'notifyringing' change and doc fix (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_sip: option 'notifyringing' change and doc fix
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1649/3/channels/chan_sip.c
File channels/chan_sip.c:

Line 14633: 		statestring = (sip_cfg.notifyringing == NOTIFYRINGING_ENABLED) ? "early" : "confirmed";
I don't see how the implementation here matches the description in sip.conf.sample - can you explain more?


-- 
To view, visit https://gerrit.asterisk.org/1649
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88f7036ee084bb3f43b74f15612695c6708f74aa
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ward van Wanrooij <ward at ward.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Ward van Wanrooij <ward at ward.nu>
Gerrit-HasComments: Yes