[Asterisk-code-review] Astobj2: Ensure all calls to adjust lock pass a valid object. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Astobj2: Ensure all calls to __adjust_lock pass a valid object.
......................................................................


Patch Set 2:

> I'm a ambivalent about this. On the one hand, it doesn't really
 > hurt anything, but on the other, I don't understand the need for
 > this. The code changes here affect containers, and containers
 > should never not be valid AO2 objects. Has there been an observed
 > problem that this is intended to solve? The referenced issue
 > doesn't shed any light on the matter.

On https://gerrit.asterisk.org/140 Richard posted a finding about __adjust_lock not checking for obj == NULL like the other lock methods.  Since any fix would apply to 13 and master, I posted a separate review.

-- 
To view, visit https://gerrit.asterisk.org/222
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I669100f87937cc3f867cec56a27ae9c01292908f
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No