[Asterisk-code-review] Astobj2: Ensure all calls to adjust lock pass a valid object. (asterisk[master])

Mark Michelson asteriskteam at digium.com
Wed Apr 22 16:29:47 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: Astobj2: Ensure all calls to __adjust_lock pass a valid object.
......................................................................


Patch Set 1:

I'm a ambivalent about this. On the one hand, it doesn't really hurt anything, but on the other, I don't understand the need for this. The code changes here affect containers, and containers should never not be valid AO2 objects. Has there been an observed problem that this is intended to solve? The referenced issue doesn't shed any light on the matter.

-- 
To view, visit https://gerrit.asterisk.org/222
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I669100f87937cc3f867cec56a27ae9c01292908f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list