[Asterisk-code-review] app confbridge: Wrong language on playback of some files (asterisk[11])

Mark Michelson asteriskteam at digium.com
Wed Apr 22 11:49:10 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: app_confbridge: Wrong language on playback of some files
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/185/1/include/asterisk/app.h
File include/asterisk/app.h:

Line 739: #define ast_play_and_record(chan, playfile, recordfile, maxtime, fmt, duration, sound_duration, silence_threshold, maxsilence, path) \
        : 	ast_play_and_record_with_language(chan, playfile, recordfile, maxtime, fmt, duration, sound_duration, silence_threshold, maxsilence, path, NULL)
There should be a new function instead of modifying this one. API changes mid-version are bad.


-- 
To view, visit https://gerrit.asterisk.org/185
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09303f368b39da02c379ea364adcc36d1d76ab89
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list