[Asterisk-code-review] app confbridge: Wrong language on playback of some files (asterisk[11])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: app_confbridge: Wrong language on playback of some files
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/185/1/main/app.c
File main/app.c:

Line 1088: 	if ((d = ast_streamfile(chan, fn, language ?: ast_channel_language(chan)))) {
Change this ternary to operate on ast_strlen_zero(language). Confbridge bridge profile launguage is an array that will never be NULL, but it can be an empty string.


https://gerrit.asterisk.org/#/c/185/1/main/file.c
File main/file.c:

Line 1466: 		res = ast_streamfile(chan, file, language ?: ast_channel_language(chan));
Same comment here about using ast_strlen_zero()


-- 
To view, visit https://gerrit.asterisk.org/185
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09303f368b39da02c379ea364adcc36d1d76ab89
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes