[Asterisk-code-review] res odbc: Use negative connection cache for all connections (asterisk[master])

[Walter Doekes]

Walter Doekes has posted comments on this change.

Change subject: res_odbc: Use negative connection cache for all connections
......................................................................


Patch Set 2:

If this means that the negative connection cache didn't use to work, but starts to work now -- with a default of 300 seconds -- I say nay.

If our Asterisken started to wait 5 minutes upon a temporary error (restarting db daemon?), we'd have serious issues.

If the above is true, then perhaps a negative_timeout default of 1 second would be better in live branches. Or at least a visible warning in the CHANGES file.

Thanks.

-- 
To view, visit https://gerrit.asterisk.org/182
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I431cc2e8584ab0b6908b3523d0a0e18c9a527271
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: No