[Asterisk-code-review] res odbc: Use negative connection cache for all connections (asterisk[master])
Kevin Harwell
asteriskteam at digium.com
Tue Apr 21 16:01:58 CDT 2015
Kevin Harwell has posted comments on this change.
Change subject: res_odbc: Use negative connection cache for all connections
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.asterisk.org/#/c/182/2/res/res_odbc.c
File res/res_odbc.c:
Line 1250: long int negative_cache_expiration = class->last_negative_connect.tv_sec + class->negative_connection_cache.tv_sec;
Remove extra space/red blob
Line 1251: if (time(NULL) < negative_cache_expiration) {
: ast_log(LOG_WARNING, "Not connecting to %s. Negative connection cache for %ld seconds\n", name, negative_cache_expiration - time(NULL));
: return NULL;
: }
Looks like a ref leak on "class". It needs its reference decremented before returning.
--
To view, visit https://gerrit.asterisk.org/182
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I431cc2e8584ab0b6908b3523d0a0e18c9a527271
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list