[Asterisk-code-review] Change in asterisk[13]: Detect potential forwarding loops based on count.

[Kevin Harwell (Code Review)]

Kevin Harwell has posted comments on this change.

Change subject: Detect potential forwarding loops based on count.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/121/2/main/max_forwards.c
File main/max_forwards.c:

Line 140: mf_datastore = ast_channel_datastore_find(chan, &max_forwards_info, NULL);
        : 	if (!mf_datastore) {
        : 		return ast_max_forwards_set(chan, DEFAULT_MAX_FORWARDS);
        : 	}
Why not go ahead and decrement the default when you initially set it when this is called the first time? If I had set a custom value to the same as the default it would be decremented on first call.


-- 
To view, visit https://gerrit.asterisk.org/121
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7e4b7cd3bccfbd34d9a859838356931bba56c23
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes