[Asterisk-code-review] Change in asterisk[13]: Detect potential forwarding loops based on count.

[Joshua Colp (Code Review)]

Joshua Colp has posted comments on this change.

Change subject: Detect potential forwarding loops based on count.
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/121/2/include/asterisk/max_forwards.h
File include/asterisk/max_forwards.h:

Line 19: #ifndef DIALED_INTERFACES_H
This is MAX_FORWARDS not a DIALED_INTERFACES header


https://gerrit.asterisk.org/#/c/121/2/main/max_forwards.c
File main/max_forwards.c:

Line 4:  * Copyright (C) 2015, mfgium, Inc.
mfgium!


Line 6:  * Mark Michelson <mmichelson at mfgium.com>
mfgium eh?


https://gerrit.asterisk.org/#/c/121/2/res/res_pjsip/pjsip_global_headers.c
File res/res_pjsip/pjsip_global_headers.c:

Line 90: 		pjsip_hdr *hdr;
       : 		pj_str_t hdr_name;
       : 		/* Only add the header if it's not already present. It's a good bet that
       : 		 * if someone already added this header, they're much smarter than us.
       : 		 */
       : 		pj_cstr(&hdr_name, iter->name);
       : 		hdr = pjsip_msg_find_hdr_by_name(tdata->msg, &hdr_name, NULL);
       : 		if (!hdr) {
       : 			ast_sip_add_header(tdata, iter->name, iter->value);
       : 		}
Is this a bug fix from something else?


https://gerrit.asterisk.org/#/c/121/2/res/res_pjsip_diversion.c
File res/res_pjsip_diversion.c:

Line 277: 	old_hdr = pjsip_msg_find_hdr_by_name(tdata->msg, &diversion_name, NULL);
        : 	if (old_hdr) {
        : 		pj_list_erase(old_hdr);
        : 	}
Bug fix?


-- 
To view, visit https://gerrit.asterisk.org/121
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7e4b7cd3bccfbd34d9a859838356931bba56c23
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes