[asterisk-bugs] [JIRA] (ASTERISK-28789) test_utils: incorrectly printing error 'declined to load'

[Alexander Traud (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=250030#comment-250030 ] 

Alexander Traud commented on ASTERISK-28789:
--------------------------------------------

Corey, you did a valuable job fixing the dependencies in general back in Nov. 2017 and Jan. 2018. However, I wonder why this mismatch happened, why it passed code review two times, and why it was not reported earlier – Asterisk 16 was released some time ago. Anyway, to sum-up a bit:
{code}/*** MODULEINFO
	<depend>...</depend>
***/{code}
means the internal module or external library is *required* at compile-time.
{code}AST_MODULE_INFO(
	.requires = "...",
);{code}
means the internal module is *required* at runtime.
{code}/*** MODULEINFO
	<use type="external">...</use>
***/{code}
means the _external_ library is *optional* at compile-time.
{code}/*** MODULEINFO
	<use type="module">...</use>
***/{code}
means the _internal_ module is *optional* at compile-time.
{code}AST_MODULE_INFO(
	.optional_modules = "...",
);{code}
means the _internal_ module is *optional* at runtime.

> test_utils: incorrectly printing error 'declined to load'
> ---------------------------------------------------------
>
>                 Key: ASTERISK-28789
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28789
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Tests/testsuite
>    Affects Versions: 16.9.0, 17.3.0
>         Environment: no OpenSSL (development) headers 
> either disabled or not found, in script ./configure
>            Reporter: Alexander Traud
>            Assignee: Alexander Traud
>            Severity: Minor
>
> Because ASTERISK-28788 was caused by a general misunderstanding, it is the job of the Asterisk Team (or the author who introduced that change) to scan the whole code whether this misunderstanding happened in other modules as well. However, because I was curious, I created a script myself, which checked whether AST_MODULE_INFO (runtime) requires a library which was optional in MODULEINFO (compile time). Because of this script, I found one other module affected.
> Again, at compile time, OpenSSL -lcrypto is optional. At runtime, OpenSSL libcrypto.so is mandatory. This time, the mismatch happened because yet another change: [679fa5f|https://gerrit.asterisk.org/8007].
> [~coreyfarrell], you were the original author of that change. Although I fixed the issue Asterisk wide, I am mentioning you in this issue report. Perhaps there are other optional / mandatory constellations of AST_MODULE_INFO / MODULEINFO  which are problematic but I do not envision.



--
This message was sent by Atlassian JIRA
(v6.2#6252)