[asterisk-bugs] [JIRA] (ASTERISK-28789) test_utils: incorrectly printing error 'declined to load'

[Alexander Traud (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=250012#comment-250012 ] 

Alexander Traud commented on ASTERISK-28789:
--------------------------------------------

In my script, I looked just at use/require. However, there are 12 modules which do not mention at all the internal library in MODULEINFO although it is declared as required in AST_MODULE_INFO:
{code}
  res_pjsip_pubsub res/res_pjsip_refer.c
 res_pjsip_session res/res_pjsip_one_touch_record_info.c
 res_pjsip_session res/res_pjsip_messaging.c
 res_pjsip_session res/res_pjsip_dtmf_info.c
 res_pjsip_session res/res_pjsip_rfc3326.c
 res_pjsip_session res/res_pjsip_empty_info.c
 res_pjsip_session res/res_pjsip_path.c
 res_pjsip_session res/res_pjsip_diversion.c
 res_pjsip_session res/res_pjsip_nat.c
                 * cdr/cdr_odbc.c
          res_adsi apps/app_getcpeid.c
          res_curl funcs/func_curl.c
func_curl,res_curl res/res_config_curl.c
{code}Anyone who takes over this? In the first step, you have to double-check whether the modules are really required at runtime. If something is optional (or not used at all), its AST_MODULE_INFO must be updated. Then, the second step is to update MODULEINFO.

> test_utils: incorrectly printing error 'declined to load'
> ---------------------------------------------------------
>
>                 Key: ASTERISK-28789
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28789
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Tests/testsuite
>    Affects Versions: 16.9.0, 17.3.0
>         Environment: no OpenSSL (development) headers 
> either disabled or not found, in script ./configure
>            Reporter: Alexander Traud
>            Assignee: Alexander Traud
>            Severity: Minor
>
> Because ASTERISK-28788 was caused by a general misunderstanding, it is the job of the Asterisk Team (or the author who introduced that change) to scan the whole code whether this misunderstanding happened in other modules as well. However, because I was curious, I created a script myself, which checked whether AST_MODULE_INFO (runtime) requires a library which was optional in MODULEINFO (compile time). Because of this script, I found one other module affected.
> Again, at compile time, OpenSSL -lcrypto is optional. At runtime, OpenSSL libcrypto.so is mandatory. This time, the mismatch happened because yet another change: [679fa5f|https://gerrit.asterisk.org/8007].
> [~coreyfarrell], you were the original author of that change. Although I fixed the issue Asterisk wide, I am mentioning you in this issue report. Perhaps there are other optional / mandatory constellations of AST_MODULE_INFO / MODULEINFO  which are problematic but I do not envision.



--
This message was sent by Atlassian JIRA
(v6.2#6252)