[asterisk-bugs] [JIRA] (ASTERISK-28801) [patch] stasis: Avoid always true warnings with clang.

[Alexander Traud (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-28801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Traud updated ASTERISK-28801:
---------------------------------------

    Attachment: clang_stasis.patch

> [patch] stasis: Avoid always true warnings with clang.
> ------------------------------------------------------
>
>                 Key: ASTERISK-28801
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28801
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/Stasis
>    Affects Versions: 13.32.0
>         Environment: clang 9.0
>            Reporter: Alexander Traud
>            Severity: Trivial
>              Labels: patch
>         Attachments: clang_stasis.patch
>
>
> Review [4541|https://reviewboard.asterisk.org/r/4541/] (ASTERISK-24917) resolved warnings raised by the compiler clang already. However, this one got missed. And, why ever, I did not notice this before although the issue was introduced with ASTERISK-20887 (Review [2339|https://reviewboard.asterisk.org/r/2339/]). This issue is present in Asterisk 13 only, because ASTERISK-28264 changed the code dramatically. However, that change was not backported to Asterisk 13, see Review [11103|https://gerrit.asterisk.org/11103].{code}stasis.c:464:14: warning: address of array 'topic->name' will always evaluate to 'true' [-Wpointer-bool-conversion]
>         if (!topic->name || res)
>             ~~~~~~~~^~~~
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)