[asterisk-bugs] [JIRA] (ASTERISK-28801) [patch] stasis: Avoid always true warnings with clang.

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=250114#comment-250114 ] 

Asterisk Team commented on ASTERISK-28801:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

> [patch] stasis: Avoid always true warnings with clang.
> ------------------------------------------------------
>
>                 Key: ASTERISK-28801
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28801
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/Stasis
>    Affects Versions: 13.32.0
>         Environment: clang 9.0
>            Reporter: Alexander Traud
>            Severity: Trivial
>              Labels: patch
>         Attachments: clang_stasis.patch
>
>
> Review [4541|https://reviewboard.asterisk.org/r/4541/] (ASTERISK-24917) resolved warnings raised by the compiler clang already. However, this one got missed. And, why ever, I did not notice this before although the issue was introduced with ASTERISK-20887 (Review [2339|https://reviewboard.asterisk.org/r/2339/]). This issue is present in Asterisk 13 only, because ASTERISK-28264 changed the code dramatically. However, that change was not backported to Asterisk 13, see Review [11103|https://gerrit.asterisk.org/11103].{code}stasis.c:464:14: warning: address of array 'topic->name' will always evaluate to 'true' [-Wpointer-bool-conversion]
>         if (!topic->name || res)
>             ~~~~~~~~^~~~
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)