[asterisk-bugs] [JIRA] (ASTERISK-28621) Enforce T.38 error correction mode at 200 ok received

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=248770#comment-248770 ] 

Asterisk Team commented on ASTERISK-28621:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

> Enforce T.38 error correction mode at 200 ok received  
> -------------------------------------------------------
>
>                 Key: ASTERISK-28621
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28621
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_t38
>    Affects Versions: 13.20.0
>            Reporter: Salah Ahmed
>            Severity: Minor
>
> Hello,
> Recently we have found, if asterisk offer T38 SDP with none error correction scheme and the endpoint respond with redundancy EC scheme, asterisk switch to that mode. As we configure the endpoint as none EC mode I think we should not switch to any other mode except none. We have made a simple change to determine the EC mode at 200 OK received using following logic.
> 1. If asterisk offer none, and anything except none in answer will be ignored.
> 2. If asterisk offer fec, answer with fec, redundancy and none will be accepted.
> 3. If asterisk offer redundancy, answer with redundancy and none will be accepted.
> Could anyone please verify the logic and the codes? 
> Thank You,
> Salah



--
This message was sent by Atlassian JIRA
(v6.2#6252)