[asterisk-bugs] [JIRA] (ASTERISK-28621) Enforce T.38 error correction mode at 200 ok received

[Salah Ahmed (JIRA)]

Salah Ahmed created ASTERISK-28621:
--------------------------------------

             Summary: Enforce T.38 error correction mode at 200 ok received  
                 Key: ASTERISK-28621
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28621
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Resources/res_pjsip_t38
    Affects Versions: 13.20.0
            Reporter: Salah Ahmed
            Severity: Minor


Hello,

Recently we have found, if asterisk offer T38 SDP with none error correction scheme and the endpoint respond with redundancy EC scheme, asterisk switch to that mode. As we configure the endpoint as none EC mode I think we should not switch to any other mode except none. We have made a simple change to determine the EC mode at 200 OK received using following logic.

1. If asterisk offer none, and anything except none in answer will be ignored.
2. If asterisk offer fec, answer with fec, redundancy and none will be accepted.
3. If asterisk offer redundancy, answer with redundancy and none will be accepted.

Could anyone please verify the logic and the codes? 

Thank You,
Salah



--
This message was sent by Atlassian JIRA
(v6.2#6252)