[asterisk-bugs] [JIRA] (ASTERISK-28113) Minor Tweak to gerrit email template to support dark theme.
Asterisk Team (JIRA)
noreply at issues.asterisk.org
Wed Oct 17 16:44:47 CDT 2018
[ https://issues.asterisk.org/jira/browse/ASTERISK-28113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=245179#comment-245179 ]
Asterisk Team commented on ASTERISK-28113:
------------------------------------------
Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.
A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.
Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
> Minor Tweak to gerrit email template to support dark theme.
> -----------------------------------------------------------
>
> Key: ASTERISK-28113
> URL: https://issues.asterisk.org/jira/browse/ASTERISK-28113
> Project: Asterisk
> Issue Type: Improvement
> Security Level: None
> Components: General
> Affects Versions: GIT
> Reporter: Corey Farrell
> Severity: Minor
>
> I have my email client configured with a dark theme, including display of white text on black background. This works well with one exception, when gerrit sends an email containing a vote the "Code-Review +1" is set to {{background-color: #d4ffd4}}. The template does not set the text color so it is white in my configuration (unreadable). I'd appreciate if you could add {{color: black}} to CommentHtml.soy in the voteStyle section:
> {noformat}
> {let $voteStyle kind="css"}
> border-radius: 3px;
> display: inline-block;
> margin: 0 2px;
> padding: 4px;
> color: black;
> {/let}
> {noformat}
> This will have no effect on most people but will make the vote readable in the color scheme of my client.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
More information about the asterisk-bugs
mailing list