[asterisk-bugs] [JIRA] (ASTERISK-28113) Minor Tweak to gerrit email template to support dark theme.

Corey Farrell (JIRA) noreply at issues.asterisk.org
Wed Oct 17 16:44:47 CDT 2018


Corey Farrell created ASTERISK-28113:
----------------------------------------

             Summary: Minor Tweak to gerrit email template to support dark theme.
                 Key: ASTERISK-28113
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28113
             Project: Asterisk
          Issue Type: Improvement
      Security Level: None
          Components: General
    Affects Versions: GIT
            Reporter: Corey Farrell
            Severity: Minor


I have my email client configured with a dark theme, including display of white text on black background.  This works well with one exception, when gerrit sends an email containing a vote the "Code-Review +1" is set to {{background-color: #d4ffd4}}.  The template does not set the text color so it is white in my configuration (unreadable).  I'd appreciate if you could add {{color: black}} to CommentHtml.soy in the voteStyle section:
{noformat}
  {let $voteStyle kind="css"}
    border-radius: 3px;
    display: inline-block;
    margin: 0 2px;
    padding: 4px;
    color: black;
  {/let}
{noformat}

This will have no effect on most people but will make the vote readable in the color scheme of my client.



--
This message was sent by Atlassian JIRA
(v6.2#6252)



More information about the asterisk-bugs mailing list