[asterisk-bugs] [JIRA] (ASTERISK-27999) Wrong SRTP use status report

[Salah Ahmed (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244382#comment-244382 ] 

Salah Ahmed commented on ASTERISK-27999:
----------------------------------------

I have submitted the patch to Gerrit,
In 2nd block, if remote_key is same on sdp return then that flag AST_SRTP_CRYPTO_OFFER_OK has being set and return from that method without further processing. So if endpoint reply with non srtp then also this flag has being set. Thats why I assume as we set that flag at receiving successful srtp response and if we don't set it while we receive same remote_key or non SRTP SDP response then we can take decision on that flag.

> Wrong SRTP use status report
> ----------------------------
>
>                 Key: ASTERISK-27999
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27999
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_pjsip
>    Affects Versions: 13.19.2
>            Reporter: Salah Ahmed
>            Assignee: Unassigned
>            Severity: Minor
>              Labels: patch, pjsip
>         Attachments: srtp_status.patch
>
>
> Hello,
> In a case while a pjsip channel make a SRTP request to an endpoint and it respond with non srtp sdp, call was continued with non srtp mode but following dialplan function report srtp is on. 
> channel(rtp,secure,audio)
> We have made a quick review on dialplan codes and found,
> File:  channels/pjsip/dialplan_functions.c
> Method: channel_read_rtp
> Line 533: snprintf(buf, buflen, "%d", media->srtp ? 1 : 0);
> srtp status is reported only by checking an object initialization. I think if an endpoint unable to respond with srtp that object might not destroyed. Now can we use any flag to determine this status?
> Thanks,
> Salah Ahmed



--
This message was sent by Atlassian JIRA
(v6.2#6252)