[asterisk-bugs] [JIRA] (ASTERISK-27999) Wrong SRTP use status report

[Richard Mudgett (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244381#comment-244381 ] 

Richard Mudgett commented on ASTERISK-27999:
--------------------------------------------

It is easier to review patches when they are up on Gerrit.  That is its purpose.  *All* patches have to go there to get merged into Asterisk.  If you don't put it there then you are leaving it to someone else with an interest in the patch to do it.

Since the patch is so small I can comment here.  Although, you really should put it up on Gerrit.
* The first change block can easily be expressed: {{snprintf(buf, buflen, "%d", (media->srtp && ast_test_flag(media->srtp, AST_SRTP_CRYPTO_OFFER_OK)) ? 1 : 0);}}
* I don't understand why the second block is deleting the line setting the AST_SRTP_CRYPTO_OFFER_OK line.

> Wrong SRTP use status report
> ----------------------------
>
>                 Key: ASTERISK-27999
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27999
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_pjsip
>    Affects Versions: 13.19.2
>            Reporter: Salah Ahmed
>            Assignee: Unassigned
>            Severity: Minor
>              Labels: patch, pjsip
>         Attachments: srtp_status.patch
>
>
> Hello,
> In a case while a pjsip channel make a SRTP request to an endpoint and it respond with non srtp sdp, call was continued with non srtp mode but following dialplan function report srtp is on. 
> channel(rtp,secure,audio)
> We have made a quick review on dialplan codes and found,
> File:  channels/pjsip/dialplan_functions.c
> Method: channel_read_rtp
> Line 533: snprintf(buf, buflen, "%d", media->srtp ? 1 : 0);
> srtp status is reported only by checking an object initialization. I think if an endpoint unable to respond with srtp that object might not destroyed. Now can we use any flag to determine this status?
> Thanks,
> Salah Ahmed



--
This message was sent by Atlassian JIRA
(v6.2#6252)