[asterisk-bugs] [JIRA] (ASTERISK-27828) Add Reason to QueueCallerAbandon

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=243180#comment-243180 ] 

Asterisk Team commented on ASTERISK-27828:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

> Add Reason to QueueCallerAbandon
> --------------------------------
>
>                 Key: ASTERISK-27828
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27828
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_queue
>    Affects Versions: 15.3.0
>            Reporter: Fernando Rossato
>         Attachments: app_queue.path
>
>
> app_queue registers in the queue_log events EXITWITHTIMEOUT, EXITEMPTY, EXITWITHKEY, and SYSCOMPAT, but does not report this in the AMI event. I changed the record_abandoned function by adding the reason parameter and modified the calls of this function including the reason, this procedure causes that reason to be informed in the QueueCallerAbandon event via AMI.
> the possible reasons are:
>  *  - NORMAL: Normal Abandon
>  *  - EXITWITHTIMEOUT: Abandon by EXITWITHTIMEOUT
>  *  - EXITEMPTY: Abandon by EXITEMPTY
>  *  - EXITWITHKEY: Abandon by EXITWITHKEY
>  *  - SYSCOMPAT: Abandon by SYSCOMPAT
> I did not find where to post file then it follows the patch below to solve this
> @@@@@@ begin of path @@@@@@
> 25a26,32
> >  * \note 2018-04-25: Add Reason to QueueCallerAbandon by Fernando Rossato <fer.rossato at gmail.com>
> >  *  - NORMAL: Normal Abandon
> >  *  - EXITWITHTIMEOUT: Abandon by EXITWITHTIMEOUT
> >  *  - EXITEMPTY: Abandon by EXITEMPTY
> >  *  - EXITWITHKEY: Abandon by EXITWITHKEY
> >  *  - SYSCOMPAT: Abandon by SYSCOMPAT
> >  *
> 1202a1210,1219
> >                               <parameter name="Reason">
> >                                       <para>The reason for the abandonment occurred.</para>
> >                                       <enumlist>
> >                                               <enum name="NORMAL"/>
> >                                               <enum name="EXITWITHTIMEOUT"/>
> >                                               <enum name="EXITEMPTY"/>
> >                                               <enum name="EXITWITHKEY"/>
> >                                               <enum name="SYSCOMPAT"/>
> >                                       </enumlist>
> >                               </parameter>
> 4706c4723
> < static void record_abandoned(struct queue_ent *qe)
> ---
> > static void record_abandoned(struct queue_ent *qe, char reason[80])
> 4717c4734
> <       blob = ast_json_pack("{s: s, s: i, s: i, s: i}",
> ---
> >       blob = ast_json_pack("{s: s, s: i, s: i, s: s, s: i}",
> 4720a4738
> >                            "Reason", reason,
> 6885c6903
> <                               record_abandoned(qe);
> ---
> >                               record_abandoned(qe, "NORMAL");
> 6905c6923
> <                       record_abandoned(qe);
> ---
> >                       record_abandoned(qe, "SYSCOMPAT");
> 8243c8261
> <                       record_abandoned(&qe);
> ---
> >                       record_abandoned(&qe, "EXITWITHTIMEOUT");
> 8270c8288
> <                       record_abandoned(&qe);
> ---
> >                       record_abandoned(&qe, "EXITWITHTIMEOUT");
> 8292c8310
> <                               record_abandoned(&qe);
> ---
> >                               record_abandoned(&qe, "EXITEMPTY");
> 8305c8323
> <                       record_abandoned(&qe);
> ---
> >                       record_abandoned(&qe, "EXITWITHTIMEOUT");
> 8314c8332
> <                       record_abandoned(&qe);
> ---
> >                       record_abandoned(&qe, "EXITWITHTIMEOUT");
> 8343c8361
> <                               record_abandoned(&qe);
> ---
> >                               record_abandoned(&qe, "NORMAL");
> @@@@@@@@ End of path @@@@@@@@@@@



--
This message was sent by Atlassian JIRA
(v6.2#6252)