[asterisk-bugs] [JIRA] (ASTERISK-27816) func_talkdetect's logic is completely broken

[Richard Mudgett (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=243109#comment-243109 ] 

Richard Mudgett commented on ASTERISK-27816:
--------------------------------------------

A third parameter is not needed.  The problem with dsp_talking_threshold is only a documentation problem as the talking threshold was never time related.  The code does not use the dsp_talking_threshold value for timing and only passes it to the DSP code.  The DSP code uses it for the signal magnitude threshold between silence and talking.  The documentation in func_talkdetect.c for dsp_silence_threshold and dsp_talking_threshold should be updated to correspond with dsp_silence_threshold and dsp_talking_threshold in app_confbridge (https://gerrit.asterisk.org/#/c/8115/).  The confbridge parameters used similar language to TALK_DETECT before being corrected to what they really meant.

There is also a cut and paste error in talk_detect_fn_write() where it uses the dsp_silence_threshold variable when it should use dsp_talking_threshold.

> func_talkdetect's logic is completely broken
> --------------------------------------------
>
>                 Key: ASTERISK-27816
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27816
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Functions/func_talkdetect
>    Affects Versions: 15.3.0
>            Reporter: Moritz Fain
>
> Logic in func_talkdetect.c is completely wrong regarding the thresholds. It is mixing millisecond thresholds (the one's that are passed to TALK_DETECT via set) with the DSP's avg. amplitude thresholds.



--
This message was sent by Atlassian JIRA
(v6.2#6252)