[asterisk-bugs] [JIRA] (ASTERISK-27816) func_talkdetect's logic is completely broken

[Moritz Fain (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-27816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=243103#comment-243103 ] 

Moritz Fain commented on ASTERISK-27816:
----------------------------------------

I see.

Regarding the TALK_DETECT function I could add a 3rd parameter to control the DSP silence threshold (in a backward compatible way).

1st parameter: talking_time_threshold (milliseconds)
2nd parameter: silence_time_threshold (milliseconds)
3nd parameter: dsp_silence_threshold (avg. magnitude)

What do you think? Currently the patch uses the default dsp_threshold from the config.


> func_talkdetect's logic is completely broken
> --------------------------------------------
>
>                 Key: ASTERISK-27816
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-27816
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Functions/func_talkdetect
>    Affects Versions: 15.3.0
>            Reporter: Moritz Fain
>
> Logic in func_talkdetect.c is completely wrong regarding the thresholds. It is mixing millisecond thresholds (the one's that are passed to TALK_DETECT via set) with the DSP's avg. amplitude thresholds.



--
This message was sent by Atlassian JIRA
(v6.2#6252)