[asterisk-bugs] [JIRA] (ASTERISK-13604) [patch] Addition of DAHDI application to call libpri functions for MWI via ISDN/CISC.

[Corey Farrell (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-13604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Farrell updated ASTERISK-13604:
-------------------------------------

    Assignee: Jeremy S
      Status: Waiting for Feedback  (was: Open)

Are you interested in pursuing this further?  If so the patch will need to be rebased so it can apply the the current {{master}} branch and it will need to go through code review.

----

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review \[1\] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines \[2\]
* Review the Code Review Checklist \[3\] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch \[4\]

When ready, submit your patch and any tests to Gerrit \[5\] for code review.

Thanks!

\[1\] https://wiki.asterisk.org/wiki/display/AST/Code+Review
\[2\] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
\[3\] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
\[4\] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
\[5\] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

> [patch] Addition of DAHDI application to call libpri functions for MWI via ISDN/CISC.
> -------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-13604
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-13604
>             Project: Asterisk
>          Issue Type: New Feature
>          Components: Channels/chan_dahdi/NewFeature
>            Reporter: Jeremy S
>            Assignee: Jeremy S
>         Attachments: chan_dahdi.c-14501.txt, chan_dahdi.c-174042-2.txt, chan_dahdi.c-174042.txt
>
>
> Many will find useful an open application which invokes libpri's pri_mwi_activate and pri_mwi_deactivate functions.
> Patch attached.
> I know next to nothing about C so here are some things that I hope others will help cleanup:
> 1. Asterisk attempts to hang up channels which wouldn't happen since this is a CISC. Example output:
> [Feb 18 15:06:55] WARNING[12069]: chan_dahdi.c:11336 pri_dchannel: Hangup requested on unconfigured channel 0/0 span 1
> [Feb 18 15:06:56] WARNING[12069]: chan_dahdi.c:10285 pri_fixup_principle: Call specified, but not found?
> [Feb 18 15:06:56] WARNING[12069]: chan_dahdi.c:11463 pri_dchannel: Hangup REQ on bad channel 0/3 on span 1
> 2. The activate and de-activate functions should be wrapped into one with a passed variable making the case difference.
> ****** ADDITIONAL INFORMATION ******
> [patch removed]



--
This message was sent by Atlassian JIRA
(v6.2#6252)