[asterisk-bugs] [JIRA] (ASTERISK-13684) [patch] export the SIP peer username of the transferer

Corey Farrell (JIRA) noreply at issues.asterisk.org
Thu Dec 14 13:36:07 CST 2017


     [ https://issues.asterisk.org/jira/browse/ASTERISK-13684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Farrell updated ASTERISK-13684:
-------------------------------------

    Assignee: klaus3000  (was: Olle Johansson)
      Status: Waiting for Feedback  (was: In Progress)

Are you interested in pursuing this further?  If so the patch will need to be rebased so it can apply the the current {{master}} branch and it will need to go through code review.

----

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review \[1\] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines \[2\]
* Review the Code Review Checklist \[3\] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch \[4\]

When ready, submit your patch and any tests to Gerrit \[5\] for code review.

Thanks!

\[1\] https://wiki.asterisk.org/wiki/display/AST/Code+Review
\[2\] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
\[3\] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
\[4\] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
\[5\] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage

> [patch] export the SIP peer username of the transferer
> ------------------------------------------------------
>
>                 Key: ASTERISK-13684
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-13684
>             Project: Asterisk
>          Issue Type: New Feature
>          Components: Channels/chan_sip/NewFeature
>            Reporter: klaus3000
>            Assignee: klaus3000
>         Attachments: app_dial--FORWARDER.diff, asterisk-patch-sip-transfer-peername-trunk.txt, patch_chan_sip_transfer_forward_peername-1.4.23.txt, patch_chan_sip_transfer_forward_peername-1.6.2.txt
>
>
> Hi!
> When a blind transfer is initiated from a SIP, often the name of the transferer is needed (e.g. billing, applying restrictions ...). Currently there is a variable called SIPTRANSFER_REFERER which contains the value of the Refered-By header - but this variable is not trustworthy, as the SIP client can put anything into this variable.
> Attached patch adds the variables SIPTRANSFERER_PEERNAME and SIPTRANSFERER_USERNAME which contain the respective SIP username (peer or user)
> ****** ADDITIONAL INFORMATION ******
> As I am not up2date with the current peer/user behavior maybe the SIPTRANSFERER_USERNAME can be removed. I greped the code and it seems that p->peername is also set in case of a SIP user, but not vice versa.



--
This message was sent by Atlassian JIRA
(v6.2#6252)



More information about the asterisk-bugs mailing list