[asterisk-bugs] [JIRA] (ASTERISK-15687) [patch] From-header parsed twice for each invite or subscription request

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-15687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=225128#comment-225128 ] 

Matt Jordan commented on ASTERISK-15687:
----------------------------------------

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]

When ready, submit your patch and any tests to Review Board [5] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage



> [patch] From-header parsed twice for each invite or subscription request
> ------------------------------------------------------------------------
>
>                 Key: ASTERISK-15687
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-15687
>             Project: Asterisk
>          Issue Type: Bug
>          Components: Channels/chan_sip/General
>            Reporter: nick_lewis
>            Severity: Minor
>         Attachments: chan_sip.c-parseonce2.patch, chan_sip.c-parseonce.patch
>
>
> The handlers in chan_sip.c for invite and subscription requests parse the from-header twice. The first time is in check_user_full and the second time is in get_destination.  
> ****** ADDITIONAL INFORMATION ******
> I suggest that there be added a function (named something like get_source) that is called before check_user(_full) and get_destination. It would parse the from-header and populate pvt->cid_num and pvt->fromdomain as required by the other two functions. (In the case of the handler for options requests it would be called before get_destination because check_user is not yet supported for that method.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)