[asterisk-bugs] [JIRA] (ASTERISK-15687) [patch] From-header parsed twice for each invite or subscription request

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-15687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=225127#comment-225127 ] 

Matt Jordan commented on ASTERISK-15687:
----------------------------------------

Given that things changed substantially from when this patch was first proposed, I'm going to go ahead and Suspend this issue. If you think there's a benefit in porting the patch to a supported version of Asterisk, please comment here and I'll be happy to re-open the issue.

That being said, posting the patch to review board would help a lot in having the patch get merged. I'll comment here with instructions on doing that.

> [patch] From-header parsed twice for each invite or subscription request
> ------------------------------------------------------------------------
>
>                 Key: ASTERISK-15687
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-15687
>             Project: Asterisk
>          Issue Type: Bug
>          Components: Channels/chan_sip/General
>            Reporter: nick_lewis
>            Severity: Minor
>         Attachments: chan_sip.c-parseonce2.patch, chan_sip.c-parseonce.patch
>
>
> The handlers in chan_sip.c for invite and subscription requests parse the from-header twice. The first time is in check_user_full and the second time is in get_destination.  
> ****** ADDITIONAL INFORMATION ******
> I suggest that there be added a function (named something like get_source) that is called before check_user(_full) and get_destination. It would parse the from-header and populate pvt->cid_num and pvt->fromdomain as required by the other two functions. (In the case of the handler for options requests it would be called before get_destination because check_user is not yet supported for that method.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)