[asterisk-bugs] [JIRA] (ASTERISK-24798) Documenation - Clarify That Format Is Set By File Name Extension In MixMonitor

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224984#comment-224984 ] 

Michael L. Young commented on ASTERISK-24798:
---------------------------------------------

Our comments crossed paths.

Here is the full log from IRC so that the context is all there:
{quote}
15:22 < X-Rob> Hmm
15:22 < X-Rob> OK, I'd like to appeal this -- https://issues.asterisk.org/jira/browse/ASTERISK-24798
15:22 < X-Rob> I don't think that MixMonitor should be changing the filename given to it.
15:22 < X-Rob> Just because 'it's always done it' doesn't make it right.
15:23 <@mjordan> I don't disagree with that
15:23 <@mjordan> there may be some issues though with Asterisk figuring out what format you meant
15:23 <@mjordan> and if you don't have that format loaded, it will probably have to fail out
15:23 < X-Rob> Nope, it's saving in the correct format
15:23 < X-Rob> it's just changing the filename
15:23 <@mjordan> right, but that's because it is using the extension that it knows for the format. Let's say that's a bad idea (which I don't disagree with)
15:24 <@mjordan> however, let's say you don't have res_format_wav49 loaded
15:24 <@mjordan> er
15:24 <@mjordan> format_wav49
15:24 <@mjordan> whatever its name is :-P
15:24 <@mjordan> what should Asterisk do?
15:24 < X-Rob> but wav49 -is- valid for that format
15:24 <@mjordan> X-Rob: Pretend you don't have the actual module loaded in Asterisk
15:24 <@mjordan> I'm thinking about beyond your specific case :-)
15:24 < X-Rob> Then mixmon should crash, or, possibly save in slin or something?
15:25 <@mjordan> I'd say that we would have to bail out of recording
15:25 < X-Rob> I think bailing would be better.
15:25 <@mjordan> if we trust the user to hand us something, and what they handed us is invalid, we have to fail
15:25 < X-Rob> Then if you checked MIXMONITOR_FILENAME it would be blank
{quote}

> Documenation - Clarify That Format Is Set By File Name Extension In MixMonitor
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24798
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24798
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_mixmonitor
>    Affects Versions: 13.1.1
>            Reporter: xrobau
>            Assignee: Michael L. Young
>            Severity: Minor
>
> I'm not sure how far back this one goes, but running mixmon with these params:
> {code}
> MixMonitor("2015/02/17/internal-300-303-20150217-051706-1424114226.982.wav49,ai(LOCAL_MIXMON_ID),/tmp/post.sh")
> {code}
> Results in the file being SAVED as internal-300-303-20150217-051706-1424114226.982.WAV
> Note the different suffix.  Mixmon itself seems unaware of this, however, as $\{MIXMONITOR_FILENAME\} reports it correctly:
> {code}
>  Set("SIP/303-00000070", "__REC_FILENAME=/var/spool/asterisk/monitor/2015/02/17/internal-300-303-20150217-051706-1424114226.982.wav49") in new stack
> {code}
> {code}
> [root at localhost callrecording]# ls -al /var/spool/asterisk/monitor/2015/02/17/internal-300-303-20150217-051706-1424114226.982.*
> -rw-rw---- 1 asterisk asterisk 3765 Feb 17 05:17 /var/spool/asterisk/monitor/2015/02/17/internal-300-303-20150217-051706-1424114226.982.WAV
> [root at localhost callrecording]#
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)