[asterisk-bugs] [JIRA] (ASTERISK-24798) Documenation - Clarify That Format Is Set By File Name Extension In MixMonitor

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-24798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224983#comment-224983 ] 

Michael L. Young commented on ASTERISK-24798:
---------------------------------------------

Who is to say that this was not the intended behavior?  I am not trying to say that the current functionality is right but you can't just start saying "bug, bug" because it doesn't match with what you would like to have happen when all along this is the way it was intended to function by whoever programmed it, it was subsequently reviewed and then accepted into the code base.

Let me clarify something.  MixMonitor is not changing the file name.  The extension being used for the final file outputted is being set by the file write functions within Asterisk.  All MixMonitor is doing is passing the requested format by using the extension that the user is specifying to these functions that are outside of MixMonitor.

The documentation that you quoted says that `MIXMONITOR_FILENAME` will _contain_ the filename used.  I guess that whoever did this programming figured that the person using this application would know what format they used and just need to extract the file name (the part before the extension).  Who knows.

I don't know of any parts of Asterisk that will save a wav49 file with the extension ".wav49".  It only knows that if someone says "I want to record a wav49 or play a wav49, the file being referred to must have an extension of .WAV".

The only thing I am wondering and would have to look into, is, if there is a way to know the file name that Asterisk is writing to instead of setting MIXMONITOR_FILENAME to the name that the user passed in.

Please don't take my comments the wrong way.  I am just trying to help clarify why things are the way they are right now and any suggestions on what should be happening can be discussed on the development list so that a patch can be contributed to improve upon the current code unless you would like to make a code contribution.

> Documenation - Clarify That Format Is Set By File Name Extension In MixMonitor
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-24798
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-24798
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_mixmonitor
>    Affects Versions: 13.1.1
>            Reporter: xrobau
>            Assignee: Michael L. Young
>            Severity: Minor
>
> I'm not sure how far back this one goes, but running mixmon with these params:
> {code}
> MixMonitor("2015/02/17/internal-300-303-20150217-051706-1424114226.982.wav49,ai(LOCAL_MIXMON_ID),/tmp/post.sh")
> {code}
> Results in the file being SAVED as internal-300-303-20150217-051706-1424114226.982.WAV
> Note the different suffix.  Mixmon itself seems unaware of this, however, as $\{MIXMONITOR_FILENAME\} reports it correctly:
> {code}
>  Set("SIP/303-00000070", "__REC_FILENAME=/var/spool/asterisk/monitor/2015/02/17/internal-300-303-20150217-051706-1424114226.982.wav49") in new stack
> {code}
> {code}
> [root at localhost callrecording]# ls -al /var/spool/asterisk/monitor/2015/02/17/internal-300-303-20150217-051706-1424114226.982.*
> -rw-rw---- 1 asterisk asterisk 3765 Feb 17 05:17 /var/spool/asterisk/monitor/2015/02/17/internal-300-303-20150217-051706-1424114226.982.WAV
> [root at localhost callrecording]#
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)