[asterisk-bugs] [JIRA] (ASTERISK-23735) Transcoding makes bad choice in high-rate translations

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=218312#comment-218312 ] 

Rusty Newton commented on ASTERISK-23735:
-----------------------------------------

That is fine. If you post it on Reviewboard as mentioned in the code review process, others can work with you to help identify the best fix.

> Transcoding makes bad choice in high-rate translations
> ------------------------------------------------------
>
>                 Key: ASTERISK-23735
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23735
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Codecs/General
>    Affects Versions: 12.2.0
>            Reporter: Richard Kenner
>            Assignee: Richard Kenner
>         Attachments: trans.diff
>
>
> In main/translate.c, generate_table_costs considers any upsample equivalent if the slin in/out profile is the same. But that's wrong. The cost should be adjusted depending on how far apart the rate are. For example siren14 to slin32 should be via slin16, not slin. I modified that table to just add to the cost the difference in the rates and that fixes this problem, but I'm not sure enough of the scaling to know if that's the right amount to adjust it by.



--
This message was sent by Atlassian JIRA
(v6.2#6252)