[asterisk-bugs] [JIRA] (ASTERISK-23735) Transcoding makes bad choice in high-rate translations

[Richard Kenner (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-23735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Kenner updated ASTERISK-23735:
--------------------------------------

    Attachment: trans.diff

As I said, I don't think this patch is completely correct, but suggests the type of fix required.


> Transcoding makes bad choice in high-rate translations
> ------------------------------------------------------
>
>                 Key: ASTERISK-23735
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23735
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Codecs/General
>    Affects Versions: 12.2.0
>            Reporter: Richard Kenner
>            Assignee: Richard Kenner
>         Attachments: trans.diff
>
>
> In main/translate.c, generate_table_costs considers any upsample equivalent if the slin in/out profile is the same. But that's wrong. The cost should be adjusted depending on how far apart the rate are. For example siren14 to slin32 should be via slin16, not slin. I modified that table to just add to the cost the difference in the rates and that fixes this problem, but I'm not sure enough of the scaling to know if that's the right amount to adjust it by.



--
This message was sent by Atlassian JIRA
(v6.2#6252)