[asterisk-bugs] [JIRA] (ASTERISK-23462) Cannot disable SIP debugging via CLI after enabling with conf file option - also 'sip set debug off' reports debugging disabled, when it really isn't

[Corey Farrell (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-23462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Farrell updated ASTERISK-23462:
-------------------------------------

    Attachment: chan_sip-sipdebug-better-output.patch

So internally sipdebug is a bitfield, where it can be enabled by config or CLI, but to be disabled it has to be disabled in both places.  The attached patch should give better output by informing the CLI user when "sip set debug off" is blocked by sipdebug=yes in sip.conf.  I welcome your input on better wording, my C is better than my English.

> Cannot disable SIP debugging via CLI after enabling with conf file option - also 'sip set debug off' reports debugging disabled, when it really isn't
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23462
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23462
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General, Core/Logging
>    Affects Versions: SVN, 12.1.0
>            Reporter: Rusty Newton
>            Severity: Trivial
>         Attachments: chan_sip-sipdebug-better-output.patch
>
>
> This is trivial, but annoying.
> h1. Problem:
> With "sipdebug=yes" set in sip.conf, SIP debugging is enabled to the console.
> Running "sip set debug off" reports:
> {noformat}
> newtonr-laptop*CLI> sip set debug off
> SIP Debugging Disabled
> {noformat}
> However, SIP debugging continues to show up.
> h1. Thoughts:
> Ideally, "sipdebug=yes" would only affect the initial state of SIP debugging when Asterisk parses the config file and loads chan_sip. Then I would expect that you could affect the state of debugging with CLI commands while working on the CLI later on. Instead it appears to override the CLI commands completely.
> If we leave this behavior we should note it in the sip.conf and on the wiki, though I'd consider it a bug that the CLI command is reporting the state falsely.
> 1. Fix it so that the CLI commands can change the SIP debugging state despite the initial state upon load.
> 2. Or, document the behavior of sipdebug=yes acting as a permanent override and fix the false report from the CLI command.



--
This message was sent by Atlassian JIRA
(v6.2#6252)