[asterisk-bugs] [JIRA] (ASTERISK-23369) [patch] Testsuite: Timeout shutting down asterisk should result in failed test

[Corey Farrell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=215790#comment-215790 ] 

Corey Farrell commented on ASTERISK-23369:
------------------------------------------

I mostly agree with your comments.  Part of the reason I didn't create an option in test-config.yaml is I didn't (don't) know how.  I'll have time to look into that next week.  I think this option should be used to find and fix all tests that have to signal kill asterisk.  After we've fixed existing tests I do think this should be enabled by default, or even hard-coded on like the attached patch.

A test not cleaning up after itself as not critical as an issue in Asterisk, but unfortunately the testsuite only supports pass, fail or skip.  My fear is that nobody looks at anything for passed tests.  I agree that if the test is broken this is not the same fail as asterisk crashing, but it is still a fail.
                
> [patch] Testsuite: Timeout shutting down asterisk should result in failed test
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23369
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23369
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Tests/testsuite
>    Affects Versions: SVN
>            Reporter: Corey Farrell
>         Attachments: testsuite-asterisk-signal-abrt.patch
>
>
> asterisk.stop() first attempts to shutdown asterisk gracefully.  If this does not complete after 10 seconds signal 9 is used.  I believe this should be signal 6 - ABRT and core dump.
> * Backtrace of all threads may give clues to why graceful shutdown is not successful.
> * Any test that fails to hangup channels needs to be fixed.
> * If the test did hangup all channels, then we have a reference leak.
> It would also be helpful to increase the graceful shutdown timeout from 10 to 20 seconds.  While testing testsuite ABRT I found a few tests that just needed a few more seconds to shutdown gracefully, mostly when more than 1 instance of asterisk was in play.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira