[asterisk-bugs] [JIRA] (ASTERISK-23369) [patch] Testsuite: Timeout shutting down asterisk should result in failed test

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-23369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=215775#comment-215775 ] 

Matt Jordan commented on ASTERISK-23369:
----------------------------------------

So... while I agree that this should be an option, I'm not convinced it should be the default.

Tests should clean up after themselves, and we should fix them - and this is a useful tool to find such tests. Tests that don't clean up properly could be a sign of a larger problem, but it may also not indicate any problem in Asterisk - for example, a test may have just decided to not hang up its channels. A test not cleaning up after itself is not as critical as an actual crash in Asterisk, or a functionality problem - and having this on by default would make it so those problems appear as equivalent.

How about a config parameter in the top most test-config.yaml file? That would let you enable the setting for an entire testsuite run.
                
> [patch] Testsuite: Timeout shutting down asterisk should result in failed test
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23369
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23369
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Tests/testsuite
>    Affects Versions: SVN
>            Reporter: Corey Farrell
>         Attachments: testsuite-asterisk-signal-abrt.patch
>
>
> asterisk.stop() first attempts to shutdown asterisk gracefully.  If this does not complete after 10 seconds signal 9 is used.  I believe this should be signal 6 - ABRT and core dump.
> * Backtrace of all threads may give clues to why graceful shutdown is not successful.
> * Any test that fails to hangup channels needs to be fixed.
> * If the test did hangup all channels, then we have a reference leak.
> It would also be helpful to increase the graceful shutdown timeout from 10 to 20 seconds.  While testing testsuite ABRT I found a few tests that just needed a few more seconds to shutdown gracefully, mostly when more than 1 instance of asterisk was in play.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira