[asterisk-bugs] [JIRA] (ASTERISK-21693) Use of possibly uninitialized value in ast_channel_hangupcause_hash_set

[Mark Murawski (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209832#comment-209832 ] 

Mark Murawski commented on ASTERISK-21693:
------------------------------------------

Actually hmm.  Looking through the history of the branch there's a change in this function.  Previously the emulate_sip_cause was initialized to 0 and now that line has been taken out leaving me to believe that it's uninitialized, but looking at the code for ao2_alloc, which uses calloc.  We're good here.

If you don't see any other instances we can close this ticket.
                
> Use of possibly uninitialized value in ast_channel_hangupcause_hash_set 
> ------------------------------------------------------------------------
>
>                 Key: ASTERISK-21693
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21693
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.3.0
>            Reporter: Mark Murawski
>            Severity: Minor
>         Attachments: chan_sip-21693.patch
>
>
> {noformat}
> Use of possibly uninitialized value in ast_channel_hangupcause_hash_set
> Fix:
> ===================================================================
> --- channels/chan_sip.c (revision 386542)
> +++ channels/chan_sip.c (working copy)
> @@ -28011,6 +28011,9 @@
>                                 if (global_store_sip_cause) {
>                                         cause_code->emulate_sip_cause = 1;
>                                 }
> +                                else {
> +                                       cause_code->emulate_sip_cause = 0;
> +                                }
>                                 ast_queue_control_data(p->owner, AST_CONTROL_PVT_CAUSE_CODE, cause_code, data_size);
>                                 ast_channel_hangupcause_hash_set(p->owner, cause_code, data_size);
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira