[asterisk-bugs] [JIRA] (ASTERISK-21693) Use of possibly uninitialized value in ast_channel_hangupcause_hash_set

[Mark Murawski (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209831#comment-209831 ] 

Mark Murawski commented on ASTERISK-21693:
------------------------------------------

channel_internal_api.c

There's also an ao2_alloc for cause_code and an uninitialized emulate_sip_cause in this function:

int ast_channel_dialed_causes_add(const struct ast_channel *chan, const struct ast_control_pvt_cause_code *cause_code, int datalen)

I haven't gotten back to this ticket because I've focused on group variables so much.  I can upload the additional patch
                
> Use of possibly uninitialized value in ast_channel_hangupcause_hash_set 
> ------------------------------------------------------------------------
>
>                 Key: ASTERISK-21693
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21693
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.3.0
>            Reporter: Mark Murawski
>            Severity: Minor
>         Attachments: chan_sip-21693.patch
>
>
> {noformat}
> Use of possibly uninitialized value in ast_channel_hangupcause_hash_set
> Fix:
> ===================================================================
> --- channels/chan_sip.c (revision 386542)
> +++ channels/chan_sip.c (working copy)
> @@ -28011,6 +28011,9 @@
>                                 if (global_store_sip_cause) {
>                                         cause_code->emulate_sip_cause = 1;
>                                 }
> +                                else {
> +                                       cause_code->emulate_sip_cause = 0;
> +                                }
>                                 ast_queue_control_data(p->owner, AST_CONTROL_PVT_CAUSE_CODE, cause_code, data_size);
>                                 ast_channel_hangupcause_hash_set(p->owner, cause_code, data_size);
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira